Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 23, 2025

πŸ€– New release

  • compression-core: 0.4.27 -> 0.4.28 (βœ“ API compatible changes)
  • compression-codecs: 0.4.27 -> 0.4.28 (βœ“ API compatible changes)
  • async-compression: 0.4.27 -> 0.4.28 (⚠ re-exported APIs from new workspace crates)

⚠ async-compression cargo-semver-checks output

Details
--- failure enum_missing: pub enum removed or renamed ---

Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/enum_missing.ron

Failed in:
  enum async_compression::Level, previously in file /tmp/.tmpPpITOb/async-compression/src/lib.rs:185

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/inherent_method_missing.ron

Failed in:
  BrotliEncoder::with_quality_and_params, previously in file /tmp/.tmpPpITOb/async-compression/src/futures/write/mod.rs:17
  BrotliEncoder::with_quality_and_params, previously in file /tmp/.tmpPpITOb/async-compression/src/tokio/write/mod.rs:17
  BrotliEncoder::with_quality_and_params, previously in file /tmp/.tmpPpITOb/async-compression/src/tokio/bufread/mod.rs:10
  BrotliEncoder::with_quality_and_params, previously in file /tmp/.tmpPpITOb/async-compression/src/futures/bufread/mod.rs:10

--- failure module_missing: pub module removed or renamed ---

Description:
A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/module_missing.ron

Failed in:
  mod async_compression::lz4, previously in file /tmp/.tmpPpITOb/async-compression/src/lz4.rs:1
  mod async_compression::zstd, previously in file /tmp/.tmpPpITOb/async-compression/src/zstd.rs:1
  mod async_compression::brotli, previously in file /tmp/.tmpPpITOb/async-compression/src/brotli.rs:1

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/struct_missing.ron

Failed in:
  struct async_compression::zstd::DParameter, previously in file /tmp/.tmpPpITOb/async-compression/src/zstd.rs:118
  struct async_compression::zstd::CParameter, previously in file /tmp/.tmpPpITOb/async-compression/src/zstd.rs:9
  struct async_compression::lz4::EncoderParams, previously in file /tmp/.tmpPpITOb/async-compression/src/lz4.rs:25
  struct async_compression::brotli::EncoderParams, previously in file /tmp/.tmpPpITOb/async-compression/src/brotli.rs:21
Changelog

compression-core

0.4.28 - 2025-08-23

Fixed

  • fix wasi ci testing and update doc in README (#367)

Other

  • Have separate package.version field for compression-* (#369)
  • Separate codecs as a separate crate, allow direct configuration (#363)
  • Release async-compression 0.4.8 (#265)
  • prepare release 0.4.7
  • prepare release 0.4.6
  • prepare release 0.4.3
  • (async-compression) prepare release 0.4.2
  • prepare release 0.4.1 (#236)
  • prepare async-compression release 0.4.0
  • add deps and license badge
  • remove references to old stream crate feature
  • update repo links
  • Update references to master branch
  • Enable testing with all possible feature sets
  • Update links in readme for repo location
  • Mention features for local testing
  • Update README.md
  • Add licenses and trivial readme

compression-codecs

0.4.28 - 2025-08-23

Fixed

  • fix wasi ci testing and update doc in README (#367)

Other

  • Have separate package.version field for compression-* (#369)
  • Fix docs.rs build for compression-codecs (#365)


This PR was generated with release-plz.

@github-actions github-actions bot changed the title chore: release v0.4.28 chore: release Aug 23, 2025
@github-actions github-actions bot force-pushed the release-plz-2025-08-23T09-25-53Z branch from dfb95d8 to 8ce58e6 Compare August 23, 2025 09:44
@NobodyXu
Copy link
Collaborator

cc @robjtede I've run cargo doc and checked that no method/module is missing, but somehow cargo-semver-checks still think it's missing.

I believe it's a false positive, and I'd like to go ahead and release 0.4.8 of async-compression, thoughts?

@robjtede
Copy link
Member

AFK for a while today but I believe you've done the due diligence correctly.

This is a case that must be hard to impossible for semver-checks to catch. I think moving items to a new crate is technically semver-major even though it won't be breaking due to reexports. Anyway, it's an exceptional case where I believe a 0.4.8 is acceptable.

Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu NobodyXu marked this pull request as ready for review August 23, 2025 10:28
@NobodyXu NobodyXu enabled auto-merge August 23, 2025 10:28
@NobodyXu NobodyXu added this pull request to the merge queue Aug 23, 2025
Merged via the queue into main with commit 86371ba Aug 23, 2025
38 checks passed
@NobodyXu NobodyXu deleted the release-plz-2025-08-23T09-25-53Z branch August 23, 2025 10:57
@codecov
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 0.00%. Comparing base (154da15) to head (2f3f3b1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #371   +/-   ##
===========================
===========================

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants